Hide more information link when there's no description on an election #9099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreslucena
added
module: elections
type: fix
andreslucena
requested changes
Mar 28, 2022
oriolgual
force-pushed
the
fix/remove-more-information-link-when-blank
branch
from
65571bb
to
97f65bc
Compare
andreslucena
requested changes
Apr 25, 2022
oriolgual
force-pushed
the
fix/remove-more-information-link-when-blank
branch
2 times, most recently
from
988ee6f
to
82b4a9c
Compare
oriolgual
force-pushed
the
fix/remove-more-information-link-when-blank
branch
from
82b4a9c
to
7e3800d
Compare
|
There's a failing spec, can you check that @oriolgual? |
oriolgual
force-pushed
the
fix/remove-more-information-link-when-blank
branch
2 times, most recently
from
bf5bbff
to
f995f2c
Compare
|
@oriolgual there are some errors in CI, can you check it again please? |
oriolgual
force-pushed
the
fix/remove-more-information-link-when-blank
branch
3 times, most recently
from
9cde4e9
to
aa4cc65
Compare
oriolgual
force-pushed
the
fix/remove-more-information-link-when-blank
branch
from
aa4cc65
to
c6ce450
Compare
ahukkanen
approved these changes
May 13, 2022
andreslucena
changed the title
andreslucena
pushed a commit
that referenced
this pull request
May 18, 2022
andreslucena
pushed a commit
that referenced
this pull request
May 19, 2022
andreslucena
pushed a commit
that referenced
this pull request
May 19, 2022
Merged
12 tasks
12 tasks
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When there's an answer without any related information, we shouldn't show the more information link.
Before that, we were showing the link even if the description was empty because the check was on the field (which is a hash) instead of the actual translated value.
📷 Screenshots