Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release/0.26-stable-bcn with latest release/0.26-stable #24

Merged
merged 90 commits into from
Sep 19, 2022

Conversation

verarojman
Copy link

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

Eero Lahdenperä and others added 30 commits April 12, 2022 11:45
* Add base url to meta image urls

* No need to have organization in every test

* Use variable iinstead repeating
* feat(timeline_entry): add title attribute and move description

* feat(timeline_entry): add title to model, form, command and type

* feat(timeline_entry): add title to seeds

* feat(timeline): add views

* chore(i18n): remove description from timeline_entry.fields

* feat(timeline_entry): add read more toggle button

* chore(timeline_entry): remove read_more toggle

* Update decidim-accountability/lib/decidim/accountability/component.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* feat(i18n): add timeline_entry tittle key

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…ecidim#9239)

* Change permissions to edit_link in initiatives' pages

* Move system spec to correct file
…9240)

* Clarify message to user when checking census

* Rename again the attachments partial file
…idim#9242)

* Fix processes count in processes group title cell

* Split columns 50/50
Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com>
…ecidim#9246)

* Add 'not answered' as a possible answer in proposals

* Update answered_at back to nil when it's 'not answered'

* Update state_published_at back to nil when it's 'not answered'
Co-authored-by: Ivan Vergés <ivan@platoniq.net>
…rative drafts' events (decidim#9146) (decidim#9248)

* Fix absolute urls on 'create assembly member' event

* Fix absolute urls on 'collaborative drafts' events
…#9249)

* Fix icon component filename for accountability

* Remove double component navbar in consultations on mobile

* Remove unused i18n string
Co-authored-by: Eero Lahdenperä <eero.lahdenpera@mainiotech.fi>
…tings (decidim#9134) (decidim#9251)

* Do not send upcoming meeting notification hidden or withdrawn meetings.

* Refactoring

Co-authored-by: roxanaopr <66411127+roxanaopr@users.noreply.github.com>
…nants (decidim#9033) (decidim#9252)

* Select only current organization conflicts

* Refactor current organization users

* Improve conflicts query

Co-authored-by: LauraJaimeC <75725233+LauraJaimeC@users.noreply.github.com>
* Send emails to trustees

* Normalize translations

* Add missing tailing newline

* Update decidim-elections/app/views/decidim/elections/trustee_mailer/notification.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Co-authored-by: Josep Jaume Rey <josepjaume@gmail.com>
decidim#9160) (decidim#9254)

* Remove trigger from meeting_form.js in order to avoid rendering error message before form completion

* Test that the error is no longer displayed on form.

Co-authored-by: roxanaopr <66411127+roxanaopr@users.noreply.github.com>
…9257)

* Add max choice alert only if theres max choices

* Update test

* Check that translation matches

Co-authored-by: Eero Lahdenperä <eero.lahdenpera@gmail.com>
…) (decidim#9260)

* Add edit and delete actions in InitiativeType admin table

* Make the banner image upload button required in Initiative Type form

* Make consistent the naming on initiatives specs

* Clean specs and use icon actions instead of URLs
…dim#9261)

* Clarify unregistered answers on surveys behavior

* Fix i18n-tasks spec
…#9262)

The controller will try to load the Election from the params but when
rendering an election that's the single one in a voting there are no
params. Instead, it's better to use the model in the cell.

Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com>
… (decidim#9263)

* Fix initiative print when there's an organization logo

* Add i18n string for members header

* Add missing margin in initiative print page

* Link to the public initiative print page from admin panel

* Remove show/print action from initiatives' admin

* Open initiative print page in new tab

* Fix spec
* Remove show more on elections

* Remove other references

* Fix spec

Co-authored-by: Josep Jaume Rey <josepjaume@gmail.com>
* Register survey resources

* Dont make surveys searchable

Co-authored-by: Eero Lahdenperä <eero.lahdenpera@gmail.com>
Co-authored-by: Eero Lahdenperä <eero.lahdenpera@mainiotech.fi>
* Use the participatory space registry instead of directly constantizing

* Fix errors with votings when sending a newsletter

Co-authored-by: Andrés Pereira de Lucena <andreslucena@gmail.com>

Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com>
…#9256)

* fix notifications where resources are missing

* Update decidim-core/config/locales/en.yml

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update notification_cell_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Co-authored-by: Ivan Vergés <ivan@platoniq.net>
…cidim#9090) (decidim#9245)

* Enforce password validation rules on 'Forgot your password?' form

* Improve guard clause for organization

* Use a not common password for user factory

* Remove unecessary Devise password_length setting

* Change default common password in seeds

* Change default common password in specs

* Change default common password in specs

* Change domain in specs to example.org

* Change default common password in specs

* Fix organization guard clause as suggested in code review
…ecidim#9255)

* fix displaying block users

* able to render ressource

* fix gemfile test

* fix gemfile test

* fix gemfile test

* refactor change

* refactor change

* linter

* add unit test

* linter

* add trait

Co-authored-by: eliegaboriau <93646702+eliegaboriau@users.noreply.github.com>
…ecidim#9269)

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
* Dynamically get the edge release branch based on the current version

* Move the current generators spec to the runtime directory

* Add spec for testing the generators edge version git branch

* Fix the repo root path at the generators runtime specs

* Require the Decidim::Generators base module for the generators tests
andreslucena and others added 18 commits July 8, 2022 10:14
…ecidim#9522)

* Remove description from questions in elections (decidim#9401)

* remove description

* remove description from tests

* send empty description to keep bulletin board happy

* fix schema

* fix question type spec

* remove description from questions in the DB

* remove failing spec

* Fix Rails version on migration

Co-authored-by: Ivan Vergés <ivan@platoniq.net>
* Return 404 when there isn't an initiative

* Fix linter offense
…decidim#9524)

* Fix transaction in answer questionnaire and validations for attachments

* Add test and fix lint

Co-authored-by: LauraJaimeC <75725233+LauraJaimeC@users.noreply.github.com>
) (decidim#9525)

* Fix steps management

* Normalize locales

* Fix spec

* Add missing translation

Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com>

Co-authored-by: Josep Jaume Rey <josepjaume@gmail.com>
Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com>
…#9392) (decidim#9526)

* Fix email subject when resource title has special characters. Add tests.

* Apply changes only for email subject

* Apply decidim sanitize only for resource title from email subject

* Change method name for email subject i18n options

Co-authored-by: roxanaopr <66411127+roxanaopr@users.noreply.github.com>
…9529)

* Fix long word breaking

* Fix word wrap on cards

Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com>
…ecidim#9531)

* Fix background-image URLs with weird characters (decidim#9468)

* Fix bad conflict resolution
* Fix cache hash on Hightlighted spaces

* Remove cache expiry time for content block cells
* Add short format to result date

* Lint file

* Update timeline date format

Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com>
…zones' to v0.26 (decidim#9535)

* Advertise users if BB connection is lost in trustees/admin zones (decidim#9442)

* add connection error modal in trustees/admin zones

* add voting via census error spec

* be more poetic

* add key ceremony spec

* provide a generic error if it is not a XHR failure

* trim whitespace

* Fix linter offenses

Co-authored-by: Ivan Vergés <ivan@platoniq.net>
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
…eeds' to v0.26 (decidim#9553)

* Remove the description field from the elections component seeds

* Remove the rest of the question descriptions from the seeds
…m#9556)

* Fix the graphiql system spec for 0.26 with newer ChromeDriver

* Remove unnecessary expectation from the spec
…#9573)

Co-authored-by: roxanaopr <66411127+roxanaopr@users.noreply.github.com>
@verarojman verarojman marked this pull request as ready for review July 20, 2022 09:44
@fblupi fblupi merged commit 715fc31 into release/0.26-stable-bcn Sep 19, 2022
@fblupi fblupi deleted the chore/update-custom-0.26 branch November 24, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants