Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove show more button on elections #9103

Merged
merged 3 commits into from May 3, 2022
Merged

Remove show more button on elections #9103

merged 3 commits into from May 3, 2022

Conversation

josepjaume
Copy link
Contributor

馃帺 What? Why?

The "show more" component wasn't properly working in this context. This removes it, as we want to show all the content.

@andreslucena andreslucena added contract: e-voting Barcelona City Council contract module: elections type: fix PRs that implement a fix for a bug labels Mar 29, 2022
@josepjaume josepjaume force-pushed the remove-show-more-on-elections branch from fe2bde1 to 7f6906f Compare April 24, 2022 10:05
@josepjaume josepjaume force-pushed the remove-show-more-on-elections branch from 7f6906f to 7166ed9 Compare April 24, 2022 10:23
andreslucena
andreslucena requested changes Apr 25, 2022
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing i18n spec, I'd said that's because we still have the read_more key (I didn't check it locally). Can you give it a look, please?

Also, there's still the helper definition, can you remove it?

decidim/decidim-elections/app/cells/decidim/votings/content_blocks/landing_page/description_cell.rb

Line 22 in e2f5b9c

def button_show_more_text

@josepjaume
Copy link
Contributor Author

Done! Thanks for the reviews, @andreslucena !

andreslucena
andreslucena approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

ahukkanen
ahukkanen approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more of these:
Changed lines

Less code, less bugs.

LGTM!

@ahukkanen ahukkanen merged commit c3b5838 into decidim:develop May 3, 2022
andreslucena pushed a commit that referenced this pull request May 6, 2022
@josepjaume @andreslucena
Remove show more button on elections (#9103)
689f976 
* Remove show more on elections

* Remove other references

* Fix spec
@andreslucena andreslucena mentioned this pull request May 6, 2022
Merged
andreslucena pushed a commit that referenced this pull request May 6, 2022
@josepjaume @andreslucena
Remove show more button on elections (#9103)
a23c8a6 
* Remove show more on elections

* Remove other references

* Fix spec
ahukkanen pushed a commit that referenced this pull request May 10, 2022
@andreslucena @josepjaume
Remove show more button on elections (#9103) (#9264)
3dcf94c 
* Remove show more on elections

* Remove other references

* Fix spec

Co-authored-by: Josep Jaume Rey <josepjaume@gmail.com>
@andreslucena andreslucena added this to Product Backlog in e-voting May 25, 2022
@andreslucena andreslucena moved this from Product Backlog to Technical Review in e-voting May 25, 2022
@andreslucena andreslucena moved this from Technical Review to Done in e-voting May 25, 2022
@verarojman verarojman mentioned this pull request Jul 14, 2022
Merged
12 tasks
@microstudi microstudi mentioned this pull request Jul 28, 2022
Closed
@oriolgual oriolgual deleted the remove-show-more-on-elections branch August 12, 2022 15:05
@microstudi microstudi mentioned this pull request Aug 26, 2022
Closed
12 tasks
@microstudi microstudi mentioned this pull request Sep 13, 2022
Merged
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

@ahukkanen ahukkanen ahukkanen approved these changes

Assignees
No one assigned
Labels
contract: e-voting Barcelona City Council contract module: elections type: fix PRs that implement a fix for a bug
Projects
No open projects
e-voting
Done
e-voting
Archived in project
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josepjaume @andreslucena @ahukkanen @alecslupu