Fix registration type field highlighted in admin meeting creation form #9160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message before form completion
andreslucena
added
module: meetings
type: fix
andreslucena
previously approved these changes
Apr 21, 2022
There was a problem hiding this comment.
I can confirm that this is working as expected locally.
I'm not sure if we should also add a regression test for this one, probably at
- what do you think @roxanaopr @ahukkanen?
|
Oh and thanks for the PR @roxanaopr!! This was the typical small thing that whenever I found it I said to myself "I need to check that" but didn't have the chance, so great that you've done it! 👏🏽 👏🏽 |
roxanaopr
force-pushed
the
fix/registration_type_form_error
branch
from
39ab604
to
5692d02
Compare
andreslucena
approved these changes
Apr 28, 2022
andreslucena
changed the title
ahukkanen
approved these changes
Apr 29, 2022
andreslucena
pushed a commit
that referenced
this pull request
May 6, 2022
#9160) * Remove trigger from meeting_form.js in order to avoid rendering error message before form completion * Test that the error is no longer displayed on form.
Merged
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Registration type field is already highlighted upon creating a meeting via admin
📌 Related Issues
Testing