New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initiative print link, margin, and organization logo #9162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreslucena
added
module: initiatives
type: fix
PRs that implement a fix for a bug
labels
Apr 13, 2022
andreslucena
changed the title
Fix initiative print when there's an organization logo
Fix initiative print link, margin, and organization logo
Apr 13, 2022
andreslucena
commented
Apr 13, 2022
decidim-initiatives/app/views/decidim/initiatives/initiatives/print.html.erb
Show resolved
Hide resolved
andreslucena
force-pushed
the
fix/initiative-print
branch
from
April 13, 2022 12:37
e9e15ad
to
ce70c09
Compare
ahukkanen
reviewed
Apr 30, 2022
decidim-initiatives/app/views/decidim/initiatives/admin/initiatives/index.html.erb
Show resolved
Hide resolved
andreslucena
force-pushed
the
fix/initiative-print
branch
from
May 2, 2022 07:15
fad049c
to
cae8972
Compare
There's a failing spec, I'll need to check it. I'll let you know when this is ready to be re-reviewed. |
I've fixed the spec. This is ready to be re-reviewed @ahukkanen |
ahukkanen
approved these changes
May 3, 2022
andreslucena
added a commit
that referenced
this pull request
May 6, 2022
* Fix initiative print when there's an organization logo * Add i18n string for members header * Add missing margin in initiative print page * Link to the public initiative print page from admin panel * Remove show/print action from initiatives' admin * Open initiative print page in new tab * Fix spec
andreslucena
added a commit
that referenced
this pull request
May 6, 2022
* Fix initiative print when there's an organization logo * Add i18n string for members header * Add missing margin in initiative print page * Link to the public initiative print page from admin panel * Remove show/print action from initiatives' admin * Open initiative print page in new tab * Fix spec
ahukkanen
pushed a commit
that referenced
this pull request
May 10, 2022
* Fix initiative print when there's an organization logo * Add i18n string for members header * Add missing margin in initiative print page * Link to the public initiative print page from admin panel * Remove show/print action from initiatives' admin * Open initiative print page in new tab * Fix spec
Merged
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This PR removes a legacy print page that we have in admin. This should have been removed when #5736 was implemented, but it was left. I've removed the action and linked to the frontend.
In the process of fixing it, I found a couple more bugs that this PR also solves:
I think it was because it wasn't migrated during the change to ActiveStorage on #7598. I've also added a regression test for this.
馃搶 Related Issues
Testing
Regarding the print initiative in admin:
馃摲 Screenshots
Before
After