Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix survey activity log entries #9173

Merged
merged 2 commits into from May 3, 2022

Conversation

lahdeero
Copy link
Contributor

@lahdeero lahdeero commented Apr 20, 2022

馃帺 What? Why?

Seeds are creating activity log entries related to surveys, but when activity feed raises error when page has activities related to survey. This happened because resource locator can't find route for the survey because it's not registered to resources manifest.

馃搶 Related Issues

Testing

Follow instructions in #8464 , note that creating survey via admin panel doesn't create activity log entry that relates to survey.

馃摲 Screenshots

image

鈾ワ笍 Thank you!

@lahdeero lahdeero changed the title Update survey and budget seeds Fix survey activity log entries Apr 20, 2022
@ahukkanen ahukkanen added type: fix PRs that implement a fix for a bug module: surveys labels Apr 30, 2022
@ahukkanen ahukkanen merged commit 6f87559 into decidim:develop May 3, 2022
@ahukkanen ahukkanen deleted the fix/survey_in_activity_feed branch May 3, 2022 11:10
andreslucena pushed a commit that referenced this pull request May 6, 2022
* Register survey resources

* Dont make surveys searchable
andreslucena pushed a commit that referenced this pull request May 6, 2022
* Register survey resources

* Dont make surveys searchable
ahukkanen pushed a commit that referenced this pull request May 10, 2022
* Register survey resources

* Dont make surveys searchable

Co-authored-by: Eero Lahdenper盲 <eero.lahdenpera@gmail.com>
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: surveys type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity feed raises error when containing entry that references to a survey
3 participants