Fix notifications where resources are missing

[microstudi]

🎩 What? Why?

It is pretty common for admins to experiments different configurations that generate notifications. For instance create a step, activate it, deactivated, delete it.
This kind of processes tend to leave some notifications to some users with orphan resources. The current cell that renders a notification does not has a guard clause to skip or show and alternative title for the notification when this happens, resulting in a frustrating 500 error that prevents access to the notification page.

This PR simply shows a message (we can change that @andreslucena) when a resource is missing for whatever reason. At least this way the user can simply discard the notification.

Testing

Create a process, create some steps in it, make sure you follow the process. Activate/deactivate some step and then delete the step. Go to notifications page, you should see a "missing event" message.

Note: this should be backported

♥️ Thank you!

[request-info]

It seems like you didn't give us much information about what you're trying to do here. We would appreciate it if you could provide us with more info about this issue/PR!

[andreslucena]

Thanks for the PR @microstudi!
We're thinking in the best course of action with @carolromero
We'll let you know when we have a clear strategy

[microstudi]

Thanks for the PR @microstudi! We're thinking in the best course of action with @carolromero We'll let you know when we have a clear strategy

Ok, but take into account that it is extremely difficult to prevent all the situations that can leave "broken" notification. This acts as a guard clause.
If you are thinking on simply not showing broken notifications, this can be more inefficient due the polymorphic nature of the resources associated.
This approach will simply let users "clean" these notification over time.

[andreslucena]

If you are thinking on simply not showing broken notifications, this can be more inefficient due the polymorphic nature of the resources associated.

Yesterday we thought about that but we realized that this also works on other scenarios, and it'd be a bit weird for the user. For instance, what happens if you receive a notification by email, go to see it in your /notificaitons page, and can't find it? With a message at least you can see that "something" has happened.

[microstudi]

Yesterday we thought about that but we realized that this also works on other scenarios, and it'd be a bit weird for the user. For instance, what happens if you receive a notification by email, go to see it in your /notificaitons page, and can't find it? With a message at least you can see that "something" has happened.

absolutely right

[andreslucena]

Failing related spec, we'll need to change it too. Can you take it a look @microstudi? Thanks

[microstudi]

This should be ready @ahukkanen

[andreslucena]

👍🏽

[ahukkanen]

🥳