Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding organization name in A2HS #9184

Merged
merged 2 commits into from Apr 29, 2022
Merged

Conversation

quinHD
Copy link
Contributor

@quinHD quinHD commented Apr 22, 2022

🎩 What? Why?

It fixes the encoding problem in the a2hs popup

📌 Related Issues

Testing

Steps to test the fix:

  1. Sign in as admin
  2. Change the Organization name to "Decidim's Populate"
  3. Save
  4. Go to frontend
  5. Add to home screen
  6. See that the Organization name is broken (see screenshot)

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
image

♥️ Thank you!

@quinHD quinHD self-assigned this Apr 22, 2022
@andreslucena
Copy link
Member

@quinHD can you add a regression test please? Thanks

@andreslucena andreslucena added module: core type: fix PRs that implement a fix for a bug contract: PWA Barcelona City Council contract labels Apr 22, 2022
@andreslucena andreslucena changed the title Fix encoding title in a2hs Fix encoding organization name in A2HS Apr 22, 2022
@quinHD
Copy link
Contributor Author

quinHD commented Apr 25, 2022

done! @andreslucena

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@andreslucena andreslucena added the release: v0.27 Issues or PRs that need to be tackled for v0.27 label Apr 26, 2022
@ahukkanen ahukkanen merged commit a7b5a4e into develop Apr 29, 2022
@ahukkanen ahukkanen deleted the fix/encoding-problem-a2hs branch April 29, 2022 14:02
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract: PWA Barcelona City Council contract module: core release: v0.27 Issues or PRs that need to be tackled for v0.27 type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoding problem in Organization's name with A2HS
4 participants