Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix newsletters and Decidim Votings #9188

Merged
merged 2 commits into from Apr 30, 2022
Merged

Fix newsletters and Decidim Votings #9188

merged 2 commits into from Apr 30, 2022

Conversation

oriolgual
Copy link
Contributor

馃帺 What? Why?

Makes Decidim::Votings compatible with newsletters. Instead of constantizing the value of the manifest name, it uses the participatory space registry to find the manifest, and from there, use the specified model class.

Also includes the changes made by @andreslucena at https://github.com/decidim/decidim/compare/fix/votings-newsletter

馃搶 Related Issues

@oriolgual oriolgual mentioned this pull request Apr 24, 2022
Closed
@andreslucena andreslucena added contract: e-voting Barcelona City Council contract module: admin module: elections type: fix PRs that implement a fix for a bug labels Apr 25, 2022
@ahukkanen ahukkanen merged commit b0aa81d into develop Apr 30, 2022
@ahukkanen ahukkanen deleted the fix/use-registry-with-newsletters branch April 30, 2022 13:19
andreslucena added a commit that referenced this pull request May 6, 2022
@oriolgual @andreslucena
Fix newsletters and Decidim Votings (#9188)
a58f371 
* Use the participatory space registry instead of directly constantizing

* Fix errors with votings when sending a newsletter

Co-authored-by: Andr茅s Pereira de Lucena <andreslucena@gmail.com>
@andreslucena andreslucena mentioned this pull request May 6, 2022
Merged
ahukkanen pushed a commit that referenced this pull request May 10, 2022
@andreslucena @oriolgual
Fix newsletters and Decidim Votings (#9188) (#9258)
d490c85 
* Use the participatory space registry instead of directly constantizing

* Fix errors with votings when sending a newsletter

Co-authored-by: Andr茅s Pereira de Lucena <andreslucena@gmail.com>

Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com>
@andreslucena andreslucena added this to Done in e-voting May 25, 2022
@verarojman verarojman mentioned this pull request Jul 14, 2022
Merged
12 tasks
@microstudi microstudi mentioned this pull request Jul 28, 2022
Closed
@ahukkanen ahukkanen mentioned this pull request Jul 28, 2022
Closed
@microstudi microstudi mentioned this pull request Aug 26, 2022
Closed
12 tasks
@microstudi microstudi mentioned this pull request Sep 13, 2022
Merged
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

Assignees
No one assigned
Labels
contract: e-voting Barcelona City Council contract module: admin module: elections type: fix PRs that implement a fix for a bug
Projects
No open projects
e-voting
Done
e-voting
Archived in project
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Votings is not compatible with Newsletters
4 participants
@oriolgual @ahukkanen @alecslupu @andreslucena