Add an option to hide the "Can I vote?" page #9191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oriolgual
force-pushed
the
feature/hide-can-i-vote
branch
from
28a6d7e
to
4c83e84
Compare
|
Fixes #9124 |
ahukkanen
added
module: elections
type: feature
ahukkanen
previously approved these changes
May 4, 2022
andreslucena
approved these changes
May 4, 2022
decidim-elections/app/commands/decidim/votings/admin/create_voting.rb
Outdated
Show resolved
Hide resolved
decidim-elections/app/commands/decidim/votings/admin/update_voting.rb
Outdated
Show resolved
Hide resolved
decidim-elections/app/forms/decidim/votings/admin/voting_form.rb
Outdated
Show resolved
Hide resolved
decidim-elections/app/views/decidim/votings/admin/votings/_form.html.erb
Outdated
Show resolved
Hide resolved
decidim-elections/spec/commands/decidim/votings/admin/create_voting_spec.rb
Outdated
Show resolved
Hide resolved
decidim-elections/spec/commands/decidim/votings/admin/create_voting_spec.rb
Outdated
Show resolved
Hide resolved
decidim-elections/spec/commands/decidim/votings/admin/create_voting_spec.rb
Outdated
Show resolved
Hide resolved
andreslucena
requested changes
May 4, 2022
oriolgual
force-pushed
the
feature/hide-can-i-vote
branch
4 times, most recently
from
0c92c2c
to
6a13ebf
Compare
|
Done @andreslucena |
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
oriolgual
force-pushed
the
feature/hide-can-i-vote
branch
from
6a13ebf
to
8c66ec7
Compare
ahukkanen
approved these changes
May 13, 2022
andreslucena
added a commit
that referenced
this pull request
May 19, 2022
* Add option to hide the "Can I vote?" link * Add missing translations for votings form * Rename to `show_check_census` Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
added a commit
that referenced
this pull request
May 19, 2022
* Add option to hide the "Can I vote?" link * Add missing translations for votings form * Rename to `show_check_census` Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Add option to hide the "Can I vote?" link * Add missing translations for votings form * Rename to `show_check_census` Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Adds an option to the votings form to be able to hide the "Can I vote?" page, this was requested after the running the simulation on the evote module.
Also adds missing translations for the votings form.
📷 Screenshots