Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly show trustees and votings menu #9192

Merged
merged 4 commits into from May 13, 2022
Merged

Correctly show trustees and votings menu #9192

merged 4 commits into from May 13, 2022

Conversation

josepjaume
Copy link
Contributor

@josepjaume josepjaume commented Apr 24, 2022 •
edited

🎩 What? Why?

This will correctly show the trustees menu when the current participatory space has an elections components. The code for votings has also been corrected as they should always be visible.

📌 Related Issues

None

Testing

Go to a "votings" participatory space with an elections component. You should see a "trustee" option on the admin.

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

image

@andreslucena andreslucena added contract: e-voting Barcelona City Council contract module: elections type: fix PRs that implement a fix for a bug labels Apr 25, 2022
@josepjaume josepjaume force-pushed the correctly-show-trustees-menu branch from 470ad9f to df0a4de Compare May 1, 2022 09:04
@josepjaume josepjaume changed the title Correctly show trustees menu Correctly show trustees and votings menu May 1, 2022
This was linked to issues May 4, 2022
Votings menu entry is not visible when on Elections page #9114
Closed
Trustee menu entry only visible when on Elections page #8188
Closed
@ahukkanen ahukkanen merged commit abad96b into decidim:develop May 13, 2022
andreslucena pushed a commit that referenced this pull request May 18, 2022
@josepjaume @andreslucena
Correctly show trustees and votings menu (#9192)
617300c 
* Correctly show trustees menu

* Always show votings

* Fix voting permissions

* Refactor conditional logic
@andreslucena andreslucena mentioned this pull request May 18, 2022
Merged
andreslucena pushed a commit that referenced this pull request May 19, 2022
@josepjaume @andreslucena
Correctly show trustees and votings menu (#9192)
0121102 
* Correctly show trustees menu

* Always show votings

* Fix voting permissions

* Refactor conditional logic
ahukkanen pushed a commit that referenced this pull request May 19, 2022
@andreslucena @josepjaume
Correctly show trustees and votings menu (#9192) (#9324)
598e926 
* Correctly show trustees menu

* Always show votings

* Fix voting permissions

* Refactor conditional logic

Co-authored-by: Josep Jaume Rey <josepjaume@gmail.com>
andreslucena pushed a commit that referenced this pull request May 19, 2022
@josepjaume @andreslucena
Correctly show trustees and votings menu (#9192)
2552467 
* Correctly show trustees menu

* Always show votings

* Fix voting permissions

* Refactor conditional logic
@andreslucena andreslucena added this to Done in e-voting May 25, 2022
@verarojman verarojman mentioned this pull request Jul 14, 2022
Merged
12 tasks
@microstudi microstudi mentioned this pull request Jul 28, 2022
Closed
@microstudi microstudi mentioned this pull request Aug 26, 2022
Closed
12 tasks
@microstudi microstudi mentioned this pull request Sep 13, 2022
Merged
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
@josepjaume @eliegaboriau
Correctly show trustees and votings menu (decidim#9192)
54dae33 
* Correctly show trustees menu

* Always show votings

* Fix voting permissions

* Refactor conditional logic
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

@alecslupu alecslupu Awaiting requested review from alecslupu

Assignees
No one assigned
Labels
contract: e-voting Barcelona City Council contract module: elections type: fix PRs that implement a fix for a bug
Projects
No open projects
e-voting
Done
e-voting
Archived in project
Milestone
0.27.0
4 participants
@josepjaume @alecslupu @ahukkanen @andreslucena