Add missing events locales #9199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreslucena
added
module: core
module: comments
type: fix
|
Hello @sdelcroix, thanks for the PR!
Don't worry, there's always a first time for everyone 馃槃 |
andreslucena
reviewed
May 2, 2022
|
There's a failing spec with the YAML format. Can you check it out? |
andreslucena
changed the title
andreslucena
approved these changes
May 11, 2022
ahukkanen
approved these changes
May 13, 2022
andreslucena
pushed a commit
that referenced
this pull request
May 18, 2022
* Add locale for the Welcome notification event * Add locales for the some events * Add locale for comment upvoted event * Fix typo on welcome message event * Fix bad sorting
andreslucena
pushed a commit
that referenced
this pull request
May 19, 2022
* Add locale for the Welcome notification event * Add locales for the some events * Add locale for comment upvoted event * Fix typo on welcome message event * Fix bad sorting
ahukkanen
pushed a commit
that referenced
this pull request
May 19, 2022
andreslucena
pushed a commit
that referenced
this pull request
May 19, 2022
* Add locale for the Welcome notification event * Add locales for the some events * Add locale for comment upvoted event * Fix typo on welcome message event * Fix bad sorting
Merged
12 tasks
12 tasks
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Add locale for the Welcome notification event * Add locales for the some events * Add locale for comment upvoted event * Fix typo on welcome message event * Fix bad sorting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
(please first excuse the poor quality of this PR which is my first ever :))
Few weeks ago I wanted to translate the first line of the notification card for the event "Welcome notification" but I didn't find the key in locales files.
Digging through the code lead me to add the locale key "welcome_notification_event" to the section related to activemodel and it worked.
Then I joined the French translation team on Crowdin but could not contribute, as the key is not present in Decidim locales files.
This PR just add some locales key related to activemodel events in order to be available in Crowdin.
馃摲 Screenshots