Clarify unregistered answers on surveys behavior #9205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahukkanen
previously approved these changes
Apr 30, 2022
|
Oh sorry, didn't notice there are failing i18n specs because of this, can you have a look please @andreslucena ? I've restarted the surveys specs which I believe has been just some issue with the test run itself. |
ahukkanen
approved these changes
May 2, 2022
andreslucena
added a commit
that referenced
this pull request
May 6, 2022
* Clarify unregistered answers on surveys behavior * Fix i18n-tasks spec
andreslucena
added a commit
that referenced
this pull request
May 6, 2022
* Clarify unregistered answers on surveys behavior * Fix i18n-tasks spec
ahukkanen
pushed a commit
that referenced
this pull request
May 10, 2022
Merged
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This PR clarifies the behavior of the 'allow unregistered answers' setting in the surveys component, as talked in #7438.
Mind that there are other topics talked there (about how to improve the fingerprinting, if it should be done with IP addresses, it there is other use cases for making multiple answers in the same browser, etc). All of those use cases and changes should need to be proposed as a new feature.
At least the original bug report was actually about a clarification on how this feature worked, so the best solution that I could get is to clarify this too in the admin dashboard.
馃搶 Related Issues
Testing
馃摲 Screenshots