Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce password validation rules on system admins #9207

Merged
merged 1 commit into from Apr 30, 2022

Conversation

andreslucena
Copy link
Member

馃帺 What? Why?

As mentioned in #9090, password validation rules aren't enforced for system admins. This PR fixes that.

馃搶 Related Issues

Testing

For new system users with the rake task:

  1. Run bin/rails decidim_system:create_admin
  2. Fill email "system2@example.org"
  3. Fill password and password confirmation "password1234".
  4. See "password is too common" error

For new system users with the rails console:

  1. bin/rails console
  2. Decidim::System::Admin.create!(email: "system2@example.org", password: "password1234", password_confirmation: "password1234")
  3. See "password is too common" error

For existing users through the system panel:

  1. Log in to /system
  2. Go to Admins
  3. Edit an admin
  4. Fill password and password confirmation "password1234".
  5. See "password is too common" error

馃摲 Screenshots

Firefox_Screenshot_2022-04-29T12-29-24 027Z

鈾ワ笍 Thank you!

@andreslucena andreslucena added module: system type: fix PRs that implement a fix for a bug labels Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: system type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants