Enable RSpec/BeNil & RSpec/BeEq for Rubocop

.rubocop-disabled.yml

@@ -102,6 +102,7 @@ Rails/EagerEvaluationLogMessage:
 
 Style/FileWrite:
   Enabled: false
+
 Rails/RedundantPresenceValidationOnBelongsTo:
   Enabled: false
 
@@ -122,8 +123,10 @@ Rails/DuplicateScope:
 
 RSpec/IdenticalEqualityAssertion:
   Enabled: false
+
 Style/StringChars:
   Enabled: false
+
 Rails/ExpandedDateRange:
   Enabled: false
 
@@ -132,13 +135,9 @@ Rails/I18nLocaleTexts:
 
 Naming/MemoizedInstanceVariableName:
   Enabled: false
-RSpec/VerifiedDoubleReference:
-  Enabled: false
-Rails/TransactionExitStatement:
-  Enabled: false
 
-RSpec/BeNil:
+RSpec/VerifiedDoubleReference:
   Enabled: false
 
-RSpec/BeEq:
+Rails/TransactionExitStatement:
   Enabled: false

decidim-accountability/spec/permissions/decidim/accountability/admin/permissions_spec.rb

@@ -21,7 +21,7 @@
         { scope: :admin, action: :create, subject: action_subject }
       end
 
-      it { is_expected.to eq true }
+      it { is_expected.to be true }
     end
 
     describe "update" do
@@ -30,7 +30,7 @@
       end
 
       context "when the resource is present" do
-        it { is_expected.to eq true }
+        it { is_expected.to be true }
       end
 
       context "when the resource is not present" do
@@ -46,7 +46,7 @@
       end
 
       context "when the resource is present" do
-        it { is_expected.to eq true }
+        it { is_expected.to be true }
       end
 
       context "when the resource is not present" do

decidim-admin/spec/commands/decidim/admin/create_component_spec.rb

@@ -55,13 +55,13 @@ module Decidim::Admin
         expect(participatory_process.components).not_to be_empty
 
         component = participatory_process.components.first
-        expect(component.settings.dummy_global_attribute_1).to eq(true)
-        expect(component.settings.dummy_global_attribute_2).to eq(false)
+        expect(component.settings.dummy_global_attribute_1).to be(true)
+        expect(component.settings.dummy_global_attribute_2).to be(false)
         expect(component.weight).to eq 2
 
         step_settings = component.step_settings[step.id.to_s]
-        expect(step_settings.dummy_step_attribute_1).to eq(true)
-        expect(step_settings.dummy_step_attribute_2).to eq(false)
+        expect(step_settings.dummy_step_attribute_1).to be(true)
+        expect(step_settings.dummy_step_attribute_2).to be(false)
       end
 
       it "traces the action", versioning: true do

decidim-admin/spec/commands/decidim/admin/create_newsletter_spec.rb

@@ -75,7 +75,7 @@ module Decidim::Admin
           expect(newsletter.author).to eq(user)
           expect(newsletter.organization).to eq(organization)
           expect(newsletter.subject.deep_stringify_keys).to eq(form.subject.deep_stringify_keys)
-          expect(newsletter.sent?).to eq(false)
+          expect(newsletter.sent?).to be(false)
           expect(newsletter.template).to be_present
           expect(newsletter.template.settings.body.stringify_keys).to eq(newsletter_body.stringify_keys.except("machine_translations"))
         end

decidim-admin/spec/commands/decidim/admin/reorder_content_blocks_spec.rb

@@ -95,7 +95,7 @@ module Decidim::Admin
 
         expect(published_block2.weight).to eq 1
         expect(unpublished_block.weight).to eq 2
-        expect(published_block1.weight).to eq nil
+        expect(published_block1.weight).to be_nil
       end
 
       it "unpublishes a published block that disappears from the order" do

decidim-admin/spec/commands/decidim/admin/transfer_user_spec.rb

@@ -53,7 +53,7 @@ module Decidim::Admin
     context "when solve conflict succeeds " do
       it "mark conflict as solved" do
         subject.call
-        expect(conflict.reload.solved).to eq(true)
+        expect(conflict.reload.solved).to be(true)
       end
 
       it "update email" do

decidim-admin/spec/commands/decidim/admin/unreport_resource_spec.rb

@@ -17,7 +17,7 @@ module Decidim::Admin
 
       it "deletes the moderation" do
         command.call
-        expect(reportable.reload.moderation).to be(nil)
+        expect(reportable.reload.moderation).to be_nil
       end
 
       it "traces the action", versioning: true do

decidim-admin/spec/commands/decidim/admin/unreport_user_spec.rb

@@ -17,7 +17,7 @@ module Decidim::Admin
 
       it "deletes the moderation" do
         command.call
-        expect(reportable.reload.user_moderation).to be(nil)
+        expect(reportable.reload.user_moderation).to be_nil
       end
 
       it "traces the action", versioning: true do

decidim-admin/spec/commands/decidim/admin/update_component_spec.rb

@@ -52,14 +52,14 @@ module Decidim::Admin
 
         expect(component["name"]["en"]).to eq("My component")
         expect(component.weight).to eq(3)
-        expect(component.settings.dummy_global_attribute_1).to eq(true)
-        expect(component.settings.dummy_global_attribute_2).to eq(false)
-        expect(component.settings.readonly_attribute).to eq(true)
+        expect(component.settings.dummy_global_attribute_1).to be(true)
+        expect(component.settings.dummy_global_attribute_2).to be(false)
+        expect(component.settings.readonly_attribute).to be(true)
 
         step_settings = component.step_settings[step.id.to_s]
-        expect(step_settings.dummy_step_attribute_1).to eq(true)
-        expect(step_settings.dummy_step_attribute_2).to eq(false)
-        expect(step_settings.readonly_step_attribute).to eq(true)
+        expect(step_settings.dummy_step_attribute_1).to be(true)
+        expect(step_settings.dummy_step_attribute_2).to be(false)
+        expect(step_settings.readonly_step_attribute).to be(true)
       end
 
       it "fires the hooks" do

decidim-admin/spec/commands/decidim/admin/update_newsletter_spec.rb

@@ -65,7 +65,7 @@ module Decidim::Admin
 
           expect(newsletter.author).to eq(user)
           expect(newsletter.subject.except("machine_translations")).to eq(form.subject.deep_stringify_keys.except("machine_translations"))
-          expect(newsletter.sent?).to eq(false)
+          expect(newsletter.sent?).to be(false)
           expect(newsletter.template).to be_present
           expect(newsletter.template.settings.body.stringify_keys).to eq(newsletter_body.stringify_keys.except("machine_translations"))
         end

decidim-admin/spec/commands/decidim/admin/update_organization_spec.rb

@@ -75,8 +75,8 @@ module Decidim::Admin
           organization.reload
 
           expect(organization.name).to eq("My super organization")
-          expect(organization.rich_text_editor_in_public_views).to eq(true)
-          expect(organization.enable_machine_translations).to eq(true)
+          expect(organization.rich_text_editor_in_public_views).to be(true)
+          expect(organization.enable_machine_translations).to be(true)
         end
       end
     end

decidim-admin/spec/commands/decidim/admin/update_static_page_spec.rb

@@ -58,7 +58,7 @@ module Decidim::Admin
           page.reload
 
           expect(page.slug).to eq("new-slug")
-          expect(page.allow_public_access).to eq(true)
+          expect(page.allow_public_access).to be(true)
         end
       end
     end

decidim-admin/spec/controllers/concerns/impersonate_users_spec.rb

@@ -27,17 +27,17 @@ class ImpersonateFakeController < Decidim::Admin::ApplicationController
             request.set_header k, [Mime[:js], Mime[:html], Mime[:xml], "text/xml", "*/*"].join(", ")
           end
           allow(controller).to receive(:request).and_return(request)
-          expect(controller.send(:check_impersonation_log_expired)).to eq(nil)
+          expect(controller.send(:check_impersonation_log_expired)).to be_nil
         end
 
         it "returns nil on non HTML responses" do
           request.set_header "HTTP_ACCEPT", [Mime[:js], Mime[:xml]].join(",")
           allow(controller).to receive(:request).and_return(request)
-          expect(controller.send(:check_impersonation_log_expired)).to eq(nil)
+          expect(controller.send(:check_impersonation_log_expired)).to be_nil
         end
 
         it "redirects when impersonated session is expired" do
-          expect(controller.send(:check_impersonation_log_expired)).to eq(nil)
+          expect(controller.send(:check_impersonation_log_expired)).to be_nil
           request.set_header "HTTP_ACCEPT", [Mime[:html], "text/html"].join(",")
 
           allow(controller).to receive(:real_user).and_return(user)

decidim-admin/spec/controllers/static_pages_controller_spec.rb

@@ -26,21 +26,21 @@ module Admin
           it "assigns the default value for the allow_public_access" do
             post :create, params: {}
 
-            expect(assigns(:form).allow_public_access).to eq(false)
+            expect(assigns(:form).allow_public_access).to be(false)
           end
         end
 
         context "when allow_public_access is given" do
           it "does not overwrite it when unchecked" do
             put :create, params: { static_page: { allow_public_access: "0" } }.with_indifferent_access
 
-            expect(assigns(:form).allow_public_access).to eq(false)
+            expect(assigns(:form).allow_public_access).to be(false)
           end
 
           it "does not overwrite it when checked" do
             post :create, params: { static_page: { allow_public_access: "1" } }.with_indifferent_access
 
-            expect(assigns(:form).allow_public_access).to eq(true)
+            expect(assigns(:form).allow_public_access).to be(true)
           end
         end
       end
@@ -75,14 +75,14 @@ module Admin
             page.update!(allow_public_access: true)
             put :update, params: { id: page.id }.with_indifferent_access
 
-            expect(assigns(:form).allow_public_access).to eq(true)
+            expect(assigns(:form).allow_public_access).to be(true)
           end
 
           it "injects it to the form when set to false" do
             page.update!(allow_public_access: false)
             put :update, params: { id: page.id }.with_indifferent_access
 
-            expect(assigns(:form).allow_public_access).to eq(false)
+            expect(assigns(:form).allow_public_access).to be(false)
           end
         end
 
@@ -91,14 +91,14 @@ module Admin
             page.update!(allow_public_access: true)
             put :update, params: { id: page.id, static_page: { allow_public_access: "0" } }.with_indifferent_access
 
-            expect(assigns(:form).allow_public_access).to eq(false)
+            expect(assigns(:form).allow_public_access).to be(false)
           end
 
           it "does not overwrite it when checked" do
             page.update!(allow_public_access: false)
             put :update, params: { id: page.id, static_page: { allow_public_access: "1" } }.with_indifferent_access
 
-            expect(assigns(:form).allow_public_access).to eq(true)
+            expect(assigns(:form).allow_public_access).to be(true)
           end
         end
       end

decidim-admin/spec/forms/static_page_form_spec.rb

@@ -152,15 +152,15 @@ module Admin
       describe "#control_public_access?" do
         context "when organization does not require authentication" do
           it "returns false" do
-            expect(subject.control_public_access?).to eq(false)
+            expect(subject.control_public_access?).to be(false)
           end
         end
 
         context "when organization requires authentication" do
           let(:organization) { create(:organization, force_users_to_authenticate_before_access_organization: true) }
 
           it "returns true" do
-            expect(subject.control_public_access?).to eq(true)
+            expect(subject.control_public_access?).to be(true)
           end
         end
       end