New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable RSpec/BeNil & RSpec/BeEq for Rubocop #9212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
dependencies
Pull requests that update a dependency file or issues that talk about updating dependencies
type: internal
PRs that aren't necessary to add to the CHANGELOG for implementers
labels
May 2, 2022
alecslupu
force-pushed
the
fix-rspec-be-eq-cops
branch
from
May 3, 2022 07:34
365c40d
to
1f1ebfc
Compare
@ahukkanen thei can now be reviewed. |
alecslupu
force-pushed
the
fix-rspec-be-eq-cops
branch
from
May 3, 2022 09:57
1f1ebfc
to
ec7096f
Compare
alecslupu
force-pushed
the
fix-rspec-be-eq-cops
branch
from
May 3, 2022 16:20
ec7096f
to
5ecd65a
Compare
ahukkanen
changed the title
Adjust Rubocop syntax to match new DSL
Enable RSpec/BeNil & RSpec/BeEq for Rubocop
May 3, 2022
ahukkanen
approved these changes
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alecslupu !
LGTM, I adjusted the title of the PR to better describe what is done in this PR alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file or issues that talk about updating dependencies
type: internal
PRs that aren't necessary to add to the CHANGELOG for implementers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π© What? Why?
This PR fixes the
RSpec/BeNil
andRSpec/BeEq
rubocop violations revealed by #9201π Related Issues
Link your PR to an issue
Testing
This PR does not add any Decidim functionality, it only fixes Rubocop issues
π Checklist
π¨ Please review the guidelines for contributing to this repository.
docs/
.π· Screenshots
Please add screenshots of the changes you're proposing