Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RSpec/BeNil & RSpec/BeEq for Rubocop #9212

Merged
merged 38 commits into from May 3, 2022

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented May 2, 2022

🎩 What? Why?

This PR fixes the RSpec/BeNil and RSpec/BeEq rubocop violations revealed by #9201

πŸ“Œ Related Issues

Link your PR to an issue

Testing

This PR does not add any Decidim functionality, it only fixes Rubocop issues

πŸ“‹ Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • βœ”οΈ DO check open PR's to avoid duplicates.
  • βœ”οΈ DO keep pull requests small so they can be easily reviewed.
  • βœ”οΈ DO build locally before pushing.
  • βœ”οΈ DO make sure tests pass.
  • βœ”οΈ DO make sure any new changes are documented in docs/.
  • βœ”οΈ DO add and modify seeds if necessary.
  • βœ”οΈ DO add CHANGELOG upgrade notes if required.
  • βœ”οΈ DO add to GraphQL API if there are new public fields.
  • βœ”οΈ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

πŸ“· Screenshots

Please add screenshots of the changes you're proposing
Description

β™₯️ Thank you!

@alecslupu alecslupu added dependencies Pull requests that update a dependency file or issues that talk about updating dependencies type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels May 2, 2022
@alecslupu alecslupu marked this pull request as draft May 2, 2022 09:00
@alecslupu alecslupu marked this pull request as ready for review May 3, 2022 07:34
@alecslupu alecslupu requested a review from ahukkanen May 3, 2022 09:19
@alecslupu
Copy link
Contributor Author

@ahukkanen thei can now be reviewed.

@ahukkanen ahukkanen changed the title Adjust Rubocop syntax to match new DSL Enable RSpec/BeNil & RSpec/BeEq for Rubocop May 3, 2022
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alecslupu !

LGTM, I adjusted the title of the PR to better describe what is done in this PR alone.

@ahukkanen ahukkanen merged commit 242a8f2 into decidim:develop May 3, 2022
@alecslupu alecslupu deleted the fix-rspec-be-eq-cops branch May 4, 2022 05:41
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file or issues that talk about updating dependencies type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants