Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid translation call #9218

Merged
merged 2 commits into from May 3, 2022

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented May 2, 2022

🎩 What? Why?

This fixes an issue with keyword arguments that broke the tests in the Ruby 3 upgrade PR after #8866 was merged.

This fixes that issue and adds some additional cleanup to that template.

📌 Related Issues

Testing

  • Using the ruby 3 branch
  • Create a private assembly
  • Add private participants to the assembly
  • Go to add more private participants to the assembly
  • See an error

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

Instead of passing in a hash, pass the keyword arguments.
@ahukkanen ahukkanen mentioned this pull request May 2, 2022
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@andreslucena andreslucena added module: admin type: fix PRs that implement a fix for a bug labels May 3, 2022
@andreslucena andreslucena merged commit 24653d3 into decidim:develop May 3, 2022
@ahukkanen ahukkanen deleted the fix/invalid-translation-call branch May 3, 2022 08:01
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: admin type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants