Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove beforeunload confirmation panel from the budgets voting #9224

Merged
merged 1 commit into from May 4, 2022
Merged

Remove beforeunload confirmation panel from the budgets voting #9224

merged 1 commit into from May 4, 2022

Conversation

lahdeero
Copy link
Contributor

@lahdeero lahdeero commented May 3, 2022

馃帺 What? Why?

Remove "beforeunload" exit notification from the budgets voting because it just adds complexity after #8387.

馃搶 Related Issues

Testing

  1. Start budget voting
  2. Click a project's title
  3. Scroll the page (without this notification doesn't always trigger)
  4. Click "Back" button in browser

馃摲 Screenshots

image

鈾ワ笍 Thank you!

@ahukkanen ahukkanen added module: budgets type: fix PRs that implement a fix for a bug labels May 3, 2022
ahukkanen
ahukkanen approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 馃憤

Tested and works great!

@ahukkanen ahukkanen merged commit 2fe472a into decidim:develop May 4, 2022
@ahukkanen ahukkanen deleted the fix/remove_beforeunload_confirmation_panel branch May 4, 2022 07:10
andreslucena pushed a commit that referenced this pull request May 6, 2022
@andreslucena
Remove beforeunload confirmation panel (#9224)
40fb8e2
@andreslucena andreslucena mentioned this pull request May 6, 2022
Merged
andreslucena pushed a commit that referenced this pull request May 6, 2022
@andreslucena
Remove beforeunload confirmation panel (#9224)
713d26b
ahukkanen pushed a commit that referenced this pull request May 10, 2022
@andreslucena
Remove beforeunload confirmation panel (#9224) (#9266)
0e70f28 
Co-authored-by: Eero Lahdenper盲 <eero.lahdenpera@mainiotech.fi>
@verarojman verarojman mentioned this pull request Jul 14, 2022
Merged
12 tasks
@microstudi microstudi mentioned this pull request Jul 28, 2022
Closed
@microstudi microstudi mentioned this pull request Aug 26, 2022
Closed
12 tasks
@microstudi microstudi mentioned this pull request Sep 13, 2022
Merged
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

Assignees
No one assigned
Labels
module: budgets type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Unnecessary beforeunload notification in budgets voting
3 participants
@lahdeero @ahukkanen @alecslupu