Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local storage protocol options for uploaders #9285

Merged
merged 6 commits into from May 16, 2022
Merged

Fix local storage protocol options for uploaders #9285

merged 6 commits into from May 16, 2022

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented May 10, 2022 •
edited

🎩 What? Why?

The newsletter images are not displayed correctly in the development environment.

I believe this also applies to all URLs fetched from the application uploaders, i.e. the uploaded attachments.

📌 Related Issues

Testing

See #9154.

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@ahukkanen ahukkanen marked this pull request as draft May 11, 2022 07:09
@ahukkanen ahukkanen marked this pull request as ready for review May 13, 2022 20:30
andreslucena
andreslucena approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked it locally, everything works well. Thanks for the PR 👍🏽

@andreslucena
Copy link
Member

There are a couple failings in CI, but they're already fixed in develop so it's safe to merge.

@andreslucena andreslucena merged commit d7d2ac1 into decidim:develop May 16, 2022
@ahukkanen ahukkanen deleted the fix/9154 branch May 16, 2022 07:57
andreslucena pushed a commit that referenced this pull request May 18, 2022
@ahukkanen @andreslucena
Fix local storage protocol options for uploaders (#9285)
df34224 
* Fix local protocol options for the application uploader

* Add specs to test the storage protocol options for the uploaders

* Fix issues with the spec ports related to uploaders

* Avoid messing with the secrets hash

* Fix generator specs after application uploader refactoring
@andreslucena andreslucena mentioned this pull request May 18, 2022
Closed
andreslucena pushed a commit that referenced this pull request May 19, 2022
@ahukkanen @andreslucena
Fix local storage protocol options for uploaders (#9285)
7ba20ea 
* Fix local protocol options for the application uploader

* Add specs to test the storage protocol options for the uploaders

* Fix issues with the spec ports related to uploaders

* Avoid messing with the secrets hash

* Fix generator specs after application uploader refactoring
andreslucena pushed a commit that referenced this pull request May 19, 2022
@ahukkanen @andreslucena
Fix local storage protocol options for uploaders (#9285)
dd9924c 
* Fix local protocol options for the application uploader

* Add specs to test the storage protocol options for the uploaders

* Fix issues with the spec ports related to uploaders

* Avoid messing with the secrets hash

* Fix generator specs after application uploader refactoring
@ahukkanen ahukkanen mentioned this pull request Jun 8, 2022
Merged
12 tasks
This was referenced Jul 26, 2022
Merged
Closed
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
@ahukkanen @eliegaboriau
Fix local storage protocol options for uploaders (decidim#9285)
323b66d 
* Fix local protocol options for the application uploader

* Add specs to test the storage protocol options for the uploaders

* Fix issues with the spec ports related to uploaders

* Avoid messing with the secrets hash

* Fix generator specs after application uploader refactoring
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees
No one assigned
Labels
module: admin target: developer-experience type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Newsletters' images aren't shown in development
3 participants
@ahukkanen @andreslucena @alecslupu