Backport 'Fix local storage protocol options for uploaders' to v0.26 #9332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix local protocol options for the application uploader * Add specs to test the storage protocol options for the uploaders * Fix issues with the spec ports related to uploaders * Avoid messing with the secrets hash * Fix generator specs after application uploader refactoring
andreslucena
added
backport
|
@andreslucena I'm not sure if we should backport this one. This changes the behavior of the ApplicationUploader for 0.26 and it also renames a method in it. Do you think we need this for 0.26? |
If we're not 100% sure about this, I think we can skip it. This is something that only developers should see, as the original bug states (#9154). Let's close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Backport #9285 to v0.26