Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add admin log when exporting a component #9390

Merged
merged 6 commits into from
Jun 8, 2022
Merged

Add admin log when exporting a component #9390

merged 6 commits into from
Jun 8, 2022

Conversation

eliegaboriau
Copy link
Contributor

🎩 What? Why?

add admin log when exporting a component

📌 Related Issues

Fixes the following tasks of #9181
- 13th : proposals
- 14th : proposal comments
- 15th : budget projects
- 23rd : accountability results
- 24th : debate comments
and bonus
- accountability comments
- meeting registrations
- meeting comments
- meeting answers

image

@eliegaboriau eliegaboriau mentioned this pull request Jun 6, 2022
Closed
50 tasks
@andreslucena andreslucena changed the title add admin log when exporting a component Add admin log when exporting a component Jun 7, 2022
ahukkanen
ahukkanen requested changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one issue with the export type translation below.

The meeting registrations export is not currently logged but I think we can leave it as a separate issue. So if you just fix the translation in this PR, its good to go for me.

decidim-core/config/locales/en.yml Outdated Show resolved Hide resolved
@ahukkanen ahukkanen added type: feature PRs or issues that implement a new feature module: core module: admin labels Jun 8, 2022
@ahukkanen ahukkanen merged commit bbe6722 into decidim:develop Jun 8, 2022
andreslucena pushed a commit that referenced this pull request Jul 6, 2022
@eliegaboriau @andreslucena
Add admin log when exporting a component (#9390)
a267664 
* add admin log when eporting a component or its comments

* lint and normalize locale

* normalize locale

* remove "registrations" from exporting meetings

* Update en.yml
eliegaboriau added a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
@eliegaboriau
Add admin log when exporting a component (decidim#9390)
af7a596 
* add admin log when eporting a component or its comments

* lint and normalize locale

* normalize locale

* remove "registrations" from exporting meetings

* Update en.yml
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

Assignees
No one assigned
Labels
module: admin module: core type: feature PRs or issues that implement a new feature
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eliegaboriau @ahukkanen @alecslupu