Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardcoded hour in election dashboard #9465

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Fix hardcoded hour in election dashboard #9465

merged 1 commit into from
Jun 23, 2022

Conversation

andreslucena
Copy link
Member

馃帺 What? Why?

While trying out decidim-elections, I found that we had a hard-coded number in an error. This PR fixes it.

Mind that, when this rule pass, the hour is shown correctly:

decidim/decidim-elections/config/locales/en.yml

Line 267 in 3c3b74c

time_before: The setup is being done <strong>at least %{hours} hours</strong> before the election starts.

Testing

Describe the best way to test or validate your PR.

  1. Change the elections.setup_minimum_hours_before_start key in development_app/config/secrets.yml to any number that isn't 3.
  2. Go to the dashboard of a new election in a participatory process
  3. See that the you have the number 3

鈾ワ笍 Thank you!

@andreslucena andreslucena added type: bug Issues that describe a bug module: elections labels Jun 23, 2022
@ahukkanen ahukkanen merged commit 3261bd7 into develop Jun 23, 2022
@ahukkanen ahukkanen deleted the fix/elections-hardcoded-hour branch June 23, 2022 08:58
@ahukkanen ahukkanen added type: fix PRs that implement a fix for a bug and removed type: bug Issues that describe a bug labels Jun 23, 2022
andreslucena added a commit that referenced this pull request Jun 29, 2022
@andreslucena
Fix hardcoded hour in election dashboard (#9465)
69d4427
andreslucena added a commit that referenced this pull request Jul 6, 2022
@andreslucena
Fix hardcoded hour in election dashboard (#9465)
ac1b6ce
andreslucena added a commit that referenced this pull request Jul 6, 2022
@andreslucena
Fix hardcoded hour in election dashboard (#9465)
0ca7779
@andreslucena andreslucena mentioned this pull request Jul 6, 2022
Merged
ahukkanen pushed a commit that referenced this pull request Jul 8, 2022
@andreslucena
Fix hardcoded hour in election dashboard (#9465) (#9528)
e110d64
andreslucena added a commit that referenced this pull request Jul 13, 2022
@andreslucena
Fix hardcoded hour in election dashboard (#9465) (#9528)
9fb9567
@verarojman verarojman mentioned this pull request Jul 14, 2022
Merged
12 tasks
@microstudi microstudi mentioned this pull request Jul 28, 2022
Closed
@microstudi microstudi mentioned this pull request Aug 26, 2022
Closed
12 tasks
@microstudi microstudi mentioned this pull request Sep 13, 2022
Merged
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
@andreslucena @eliegaboriau
Fix hardcoded hour in election dashboard (decidim#9465)
2cf1ddf
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

Assignees
No one assigned
Labels
module: elections type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreslucena @ahukkanen @alecslupu