Fix superposition in admin's error forms #9871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreslucena
changed the title
ahukkanen
requested changes
Oct 4, 2022
There was a problem hiding this comment.
This makes perfect sense for me since the admin panel won't be handled in the 0.28 release. We should keep it looking as close to the current version as possible.
There is just one change I'd like to suggest here.
When we display dynamic form errors, they currently appear under the field as so:
But as you show in the PR description, the server-side errors appear under the label.
Maybe we should be consistent here and also move the abide errors next to the label?
This happens in the Decidim::FormBuilder class, I believe the field_with_validations method.
andreslucena
force-pushed
the
fix/admin-error-forms
branch
from
841f3ae
to
580344f
Compare
Done. It's ready to be reviewed again. |
ahukkanen
approved these changes
Oct 17, 2022
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Remove unecessary margins from admin's error forms * Move validation errors after the input field
This was referenced Oct 26, 2022
entantoencuanto
added a commit
that referenced
this pull request
Oct 26, 2022
* develop: (35 commits) Install turbo-rails (#9881) Fix conference invitations (#9664) Fix invalid rendering of meeting and proposal body texts (#9764) Make documentation site work with multiple versions (#9917) Bump versions on install docs (#9916) Standardize CSV import formats and fix private users CSV import with invalid file (#9627) Fix: The i18n locales selector is showing a dropdown with 3 languages (#9902) Make Scopes field in debates translatable (#9903) Make ToS agreement translatable (#9909) Fix issues with a11y specs (#9929) Remove invitations badge (#9906) Make initiatives order translatable (#9905) Add missing active actions on admin navigation menu (#9904) Fix user sign up with invalid name (#9896) Remove duplication of LastActivity queries (#9895) Rename IgnoredMethods to AllowedMethods in Rubocop configuration (#9893) Exclude malformed file from codeclimate configuration (#9910) Fix correct resource linking for amendments (#9887) Fix superposition in admin's error forms (#9871) Add missing i18n key in Initiatives (#9892) ...
entantoencuanto
added a commit
that referenced
this pull request
Oct 31, 2022
* develop: (36 commits) Fix proposal etiquette and length validator with base64 images (#9639) Install turbo-rails (#9881) Fix conference invitations (#9664) Fix invalid rendering of meeting and proposal body texts (#9764) Make documentation site work with multiple versions (#9917) Bump versions on install docs (#9916) Standardize CSV import formats and fix private users CSV import with invalid file (#9627) Fix: The i18n locales selector is showing a dropdown with 3 languages (#9902) Make Scopes field in debates translatable (#9903) Make ToS agreement translatable (#9909) Fix issues with a11y specs (#9929) Remove invitations badge (#9906) Make initiatives order translatable (#9905) Add missing active actions on admin navigation menu (#9904) Fix user sign up with invalid name (#9896) Remove duplication of LastActivity queries (#9895) Rename IgnoredMethods to AllowedMethods in Rubocop configuration (#9893) Exclude malformed file from codeclimate configuration (#9910) Fix correct resource linking for amendments (#9887) Fix superposition in admin's error forms (#9871) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
While reviewing #9786 I saw that we've broken the error forms on admin panel. This is probably related with the Redesign process, and as it's CSS I was hesitant to make this PR.
My reasoning is that this only applies to the admin panel and for troubleshooting we need to see the error messages. Also, as the admin panel redesign will not be ready for v0.28 (we would only have the public interface redesign for that version) I think that we need to tackle these kinds of issues on admin UX.
Feel free to correct me or close this PR as wontfix if you don't see it clear.
Testing
For instance:
馃摲 Screenshots
Before
After
Mind that there's more job to be made here regarding the margins. We could tackle that on this same PR, another PR, or during the admin Redesign. Whatever strategy you prefer.