Allow any network and related enhancements #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2021
JonathonReinhart
force-pushed
the
allow-any-net
branch
2 times, most recently
from
9334ebf
to
3cc566c
Compare
peerIP = net.ParseIP(addr.IP.String())
can be simplified to just:
peerIP = addr.IP
but we can also skip the safe cast since we know the net.Addr will always
be net.TCPAddr because we only have TCP listeners.
This has several benefits: - Configuration errors are caught at startup rather than upon a connection - connectionChecker() has less work to do for each connection
JonathonReinhart
force-pushed
the
allow-any-net
branch
from
3cc566c
to
918df65
Compare
|
Force-pushed to fix a merge conflict. Also made some superficial improvements in an error message and in |
This was referenced Nov 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the
allowed_netsconfig option to be an empty string which means "any network", without having to enter0.0.0.0/0 ::/0.It also re-works the way
allowed_netsis parsed to make several improvements:This PR is a result of discussions on #13 and is inspired by grafana#4.
Follows #15.