Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard mail if remote_host is not set #16

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Discard mail if remote_host is not set #16

merged 1 commit into from
Mar 13, 2021

Conversation

JonathonReinhart
Copy link
Collaborator

This is useful in test environments.

Follows #15.

@JonathonReinhart JonathonReinhart mentioned this pull request Mar 13, 2021
Closed
decke
decke approved these changes Mar 13, 2021
View reviewed changes
Copy link
Owner

@decke decke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and also aligns the default value to the ini file.

config.go Show resolved Hide resolved
@decke
Copy link
Owner

decke commented Mar 13, 2021

I am not sure where the other 3 commits in this PR are coming from and they don't seem to be related. Please check that first.

decke
decke reviewed Mar 13, 2021
View reviewed changes
Copy link
Owner

@decke decke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those commits do nit seem to be related to this PR.

@JonathonReinhart
Discard mail if remote_host is not set
20ca816 
This is useful for test environments.
@JonathonReinhart JonathonReinhart marked this pull request as ready for review March 13, 2021 15:16
@JonathonReinhart
Copy link
Collaborator Author

other 3 commits in this PR

Yeah, #16, #17, and #18 were all necessarily based on top of my branch from #15 because of the logging. Now that #15 is merged, I've re-based all three of those branches onto master, and dropped the "Draft" status from the PRs.

@decke decke merged commit 2475cad into master Mar 13, 2021
@JonathonReinhart JonathonReinhart deleted the discard branch March 14, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decke decke decke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathonReinhart @decke