[node-group] Fix remove taints patch from master NG #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
yalosev
added
e2e/use/cri/containerd
e2e/run/yandex-cloud
|
🟢 Workflow details🟢 |
github-actions
bot
removed
the
e2e/run/yandex-cloud
diafour
reviewed
Oct 23, 2022
diafour
reviewed
Oct 23, 2022
Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com> Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
|
better
|
name212
approved these changes
Oct 23, 2022
|
E2E was passed. We had just comments changes after the test |
diafour
approved these changes
Oct 23, 2022
nabokihms
approved these changes
Oct 23, 2022
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2022
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com> Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
|
Cherry pick PR 2814 to the branch release-1.37 successful! |
deckhouse-BOaTswain
added a commit
that referenced
this pull request
Oct 23, 2022
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com> Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com> Signed-off-by: Yuriy Losev <yuriy.losev@flant.com> Co-authored-by: Yuriy Losev <yuriy.losev@flant.com> Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
|
/backport 1.38 |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com> Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
|
Cherry pick PR 2816 to the branch release-1.38 successful! |
deckhouse-BOaTswain
added a commit
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com> Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com> Signed-off-by: Yuriy Losev <yuriy.losev@flant.com> Co-authored-by: Yuriy Losev <yuriy.losev@flant.com> Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuriy Losev yuriy.losev@flant.com
Description
Remove "master" taint if "control-plane" taint is removed
Why do we need it, and what problem does it solve?
When we are bootstraping a new single master cluster, we use command
kubectl patch nodegroup master --type json -p '[{"op": "remove", "path": "/spec/nodeTemplate/taints"}]'for removing node taints.Meanwhile our NG master only has:
and if kubernetes version < 1.24 - kubeadm sets both taints for the master node during the bootstrap process:
After patching the master NG only
control-planetaint will be removed explicitly. We also have to removemastertaint ifcontrol-planetaint was removed, otherwise cluster will not be bootstrapped.What is the expected result?
Checklist
Changelog entries