Backport: [node-group] Fix remove taints patch from master NG #2816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuriy Losev yuriy.losev@flant.com
Description
Remove "master" taint if "control-plane" taint is removed
Why do we need it, and what problem does it solve?
When we are bootstraping a new single master cluster, we use command
kubectl patch nodegroup master --type json -p '[{"op": "remove", "path": "/spec/nodeTemplate/taints"}]'
for removing node taints.Meanwhile our NG master only has:
and if kubernetes version < 1.24 - kubeadm sets both taints for the master node during the bootstrap process:
After patching the master NG only
control-plane
taint will be removed explicitly. We also have to removemaster
taint ifcontrol-plane
taint was removed, otherwise cluster will not be bootstrapped.What is the expected result?
Checklist
Changelog entries