[dhctl] feat(dhctl-for-commander): add more grpc services #8455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faroyam
changed the title
github-actions
bot
added
type/dependencies
faroyam
force-pushed
the
feat/dhctl-for-commander-server-rpc
branch
2 times, most recently
from
ab09b80
to
a719d12
Compare
faroyam
force-pushed
the
feat/dhctl-for-commander-server-rpc
branch
from
a719d12
to
381356e
Compare
faroyam
added
e2e/run/aws
|
⚪ Workflow details |
|
⚪ Workflow details |
|
/e2e/abort openstack;Standard;containerd;1.25 9202480859 9202480859-1-con-1-25 /sys/deckhouse-oss/install:pr8455 redos@31.129.32.110 |
|
🔴 Workflow details (1 job failed)🔴 |
aleksey-su
approved these changes
May 27, 2024
Signed-off-by: Ilya Mayorov <ilya.mayorov@flant.com>
faroyam
force-pushed
the
feat/dhctl-for-commander-server-rpc
branch
from
381356e
to
5b9f113
Compare
z9r5
added
e2e/run/yandex-cloud
|
🟢 Workflow detailsYandex.Cloud-WithoutNAT-Containerd-1.25 - Connection string: 🟢 |
github-actions
bot
removed
the
e2e/run/yandex-cloud
Merged
|
Cherry pick PR 8534 to the branch release-1.60 successful! |
deckhouse-BOaTswain
added a commit
that referenced
this pull request
May 29, 2024
) (#8534) Signed-off-by: Ilya Mayorov <ilya.mayorov@flant.com> Co-authored-by: Ilya Mayorov <37873799+faroyam@users.noreply.github.com> Co-authored-by: Timofey Kirillov <timofey.kirillov@flant.com>
This was referenced May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add bootstrap, converge, destroy, abort, import grpc services. We need them in Deckhouse Commander.
Why do we need it, and what problem does it solve?
This PR adds operations which lacked in the current version of dhctl-server, making it fully basically implemented (in the current version only check and bootstrap implemeneted).
This PR also fixes all operations logical errors related to the rpc operation messages processing, making it more stable and actually working.
Why do we need it in the patch release (if we do)?
This is change that corrects dhctl-server which was firstly introduced in the 1.60 release. So it is preferred to include this change into 1.60 release. Because after this change dhctl-server in the 1.60 release will stabilize more and will be equipped with full set of basic operations.
What is the expected result?
It is not expected to change anything outside of pkg/server scope by this PR.