Backport: [dhctl] chore(dhctl-for-commander): renamed and moved import operation to commander/attach #8535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mander/attach (#8482) Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
deckhouse-BOaTswain
deleted the
cherry-pick-release-1.60-c690b68e476bdb72dc501d69eab9f3baffcf876a
branch
github-actions
bot
added
area/cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed import dhctl operation to so called commander/attach operation. This rename includes pkg/operations and dhctl-server grpc method AttachCommander.
This PR depends on #8455.
Why do we need it, and what problem does it solve?
Import was a wrongly chose name, attach is more correct. There will be commander/detach operation in future versions.
Why do we need it in the patch release (if we do)?
This is change that corrects import operation and dhctl-server which were firstly introduced in the 1.60 release. So it is preferred to include this change into 1.60 release.
What is the expected result?
It is not expected to change anything outside of pkg/server or pkg/operations/import scope by this PR.