-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAB-22] User auth #12
Conversation
I tried running on localhost, do we want to implement the following?
these could be put into jira task and implemented later in another branch |
I also tried to do a post req in homepage and did not find the token in header of request, is this in scope?
mayba need interceptor along the lines of below? (copied from impensa)
|
|
||
const auth = { | ||
saveToken: (token: AxiosResponse<any>) => { | ||
localStorage.setItem(TOKEN_KEY, token.headers.authorization); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more thing @wahyuadt , in this file u save the token "Bearer abcdef..." as is, that exact format (with Bearer) is needed for rest API requests, but for websocket requests, the only thing needed it the token part (WITHOUT Bearer), so I think its better to save only the "abcdef..." part, and in interceptor, append it to "Bearere "
No description provided.