Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-63] gallery page #25

Merged
merged 15 commits into from
Aug 26, 2021
Merged

[FAB-63] gallery page #25

merged 15 commits into from
Aug 26, 2021

Conversation

wahyuadt
Copy link
Contributor

@wahyuadt wahyuadt commented Aug 20, 2021

  • Gallery page
  • Delete Session/Story

@daystram daystram temporarily deployed to Development August 22, 2021 07:49 Inactive
@daystram daystram temporarily deployed to Development August 22, 2021 07:49 Inactive
@daystram daystram temporarily deployed to Development August 22, 2021 07:52 Inactive
@wahyuadt wahyuadt marked this pull request as ready for review August 25, 2021 13:31
@daystram
Copy link
Contributor

Should audio playing and text TTS be included here? @nicolauscg @wahyuadt

@nicolauscg
Copy link
Member

some points to consider after running locally, could wait for a complete review to be done before addressing these

  • add button in classroom to go to gallery list page?
  • on gallery list page, include classroom name?

@wahyuadt
Copy link
Contributor Author

Should audio playing and text TTS be included here? @nicolauscg @wahyuadt

are the audio function ready? also i quoted something from the jira board
"also need to refactor Canvas component," is this still a thing

@nicolauscg
Copy link
Member

nicolauscg commented Aug 26, 2021

Should audio playing and text TTS be included here? @nicolauscg @wahyuadt

I think Will could continue with that, maybe could be in another PR, we should either try to manually put audio and text data on dev.daystram static folder for Will to locally test with or setup Postman to mock everything, havent checked if this is possible

@nicolauscg
Copy link
Member

nicolauscg commented Aug 26, 2021

Should audio playing and text TTS be included here? @nicolauscg @wahyuadt

are the audio function ready? also i quoted something from the jira board
"also need to refactor Canvas component," is this still a thing

yes I think a new canvas component should be created that will only display stuff, play audio and on text block click, do speech synthesis (cant draw or drag textboxes). That may require changes to exisitng Canvas component later on to reduce duplication.

Audio might not be totally fixed yet(?) but text should be good to go, so if we decide for Will to continue this, could start by allowing text boxes in gallery to be clickable

@daystram daystram temporarily deployed to Development August 26, 2021 05:05 Inactive
@daystram daystram temporarily deployed to Development August 26, 2021 05:05 Inactive
@daystram daystram temporarily deployed to Development August 26, 2021 05:07 Inactive
@daystram
Copy link
Contributor

Should audio playing and text TTS be included here? @nicolauscg @wahyuadt

are the audio function ready? also i quoted something from the jira board
"also need to refactor Canvas component," is this still a thing

yes I think a new canvas component should be created that will only display stuff, play audio and on text block click, do speech synthesis (cant draw or drag textboxes). That may require changes to exisitng Canvas component later on to reduce duplication.

Audio might not be totally fixed yet(?) but text should be good to go, so if we decide for Will to continue this, could start by allowing text boxes in gallery to be clickable

Alright, I've updated the task list

@daystram daystram marked this pull request as draft August 26, 2021 05:13
@daystram daystram marked this pull request as ready for review August 26, 2021 06:56
@daystram
Copy link
Contributor

All G

@daystram daystram merged commit e2f0fb7 into master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants