Feature: Add (optional) wind forecast #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to add wind speed and direction to the weather bar.
decompil3d
requested changes
Oct 15, 2022
Co-authored-by: Jonathan Keslin <decompil3d@users.noreply.github.com>
|
Oh, and please also add tests for this new functionality. |
|
Ah, sorry - I didn't see the tests. I'll have a go at adding some tests later (or perhaps tomorrow). |
decompil3d
requested changes
Oct 15, 2022
|
I've implemented the fix, and added tests for not showing wind by default and showing wind (based on existing test data, though I've added the wind speed unit) if enabled. Are there any other tests you'd particularly like to see for this PR? |
decompil3d
approved these changes
Oct 17, 2022
|
Going to merge this and then do a fast-follow to add other locale translations and maybe adjust styling a smidge. Thanks again for your contribution. I'll try to comment here with the version to expect the change in. |
|
Released in 4.5.0 -- should be up in HACS shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to add wind speed and direction to the weather bar. It's opt-in so that existing users won't see any unexpected change.