Add (optional) precipitation amount #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to display precipitation amounts.
decompil3d
requested changes
Oct 17, 2022
| @@ -339,6 +344,22 @@ export class HourlyWeatherCard extends LitElement { | |||
| return temperatures; | |||
| } | |||
|
|
|||
| private getPrecipitation(forecast: ForecastSegment[], numSegments: number, offset: number, unit: string): SegmentPrecipitation[] { | |||
There was a problem hiding this comment.
This can stay as-is since it'll be easy to add precipitation probability into the objects later.
Allows for a future PR to add the chance of precipitation without renaming this option. Co-authored-by: Jonathan Keslin <decompil3d@users.noreply.github.com>
|
Sure, that makes sense to me. Thanks for the suggested changes; that saved me some time finding all the places that needed changing (though you did miss one, which I've sorted in a subsequent commit). |
decompil3d
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to display precipitation amounts.
I noticed that there's a feature request for precipitation amounts, so I've implemented it following the same patterns as in #182 (wind forecast).
Closes #142