Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code in ScalarTest and equalsAndHashCode() #19

Closed
salikjan opened this issue Jan 10, 2017 · 4 comments
Closed

Remove unused code in ScalarTest and equalsAndHashCode() #19

salikjan opened this issue Jan 10, 2017 · 4 comments

Comments

@salikjan
Copy link
Contributor

salikjan commented Jan 10, 2017

Code snippet is never used:

final Scalar<String> nullScalar = new Scalar<String>(
            Arrays.asList(Mockito.mock(AbstractNode.class)),
            null
);
@amihaiemil
Copy link
Member

@salikjan thanks for opening this!

I actually wanted to point out (I somehow forgot to mention it).
Any question you have about the code, anything you see that you don't understand or think could be improved - open an issue about it and we'll discuss it :)

@amihaiemil
Copy link
Member

@salikjan Should I assign this to you? :P

@salikjan
Copy link
Contributor Author

@amihaiemil yep )

salikjan added a commit to salikjan/camel-yaml that referenced this issue Jan 11, 2017
amihaiemil added a commit that referenced this issue Jan 11, 2017
@amihaiemil
Copy link
Member

@salikjan thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants