This repository has been archived by the owner on Jun 4, 2018. It is now read-only.
Protect access to the shared Wallet structure. #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK if you add some UT. |
|
fantastic tOK |
Because both the UI thread and the wallet RPC synchronization tasks may access the wallet structure at the same time, access to the structure must be synchronized. Add a new Mutex<T> type which when unlocked, provides access to the underlying locked instance (in this case, the Wallet). This ensures that (unless the wallet reference is leaked outside of the exclusive access) all access to the wallet only occurs when the lock is held. This is also preferable to acquiring a private mutex in each of the Wallet's public APIs as it allows multiple public APIs to be called without any other tasks from changing wallet state inbetween calls. The mutex can only be acquired asynchronously. This ensures that the UI thread never blocks attempting to access wallet state. Fixes #114.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because both the UI thread and the wallet RPC synchronization tasks
may access the wallet structure at the same time, access to the
structure must be synchronized. Add a new Mutex type which when
unlocked, provides access to the underlying locked instance (in this
case, the Wallet). This ensures that (unless the wallet reference is
leaked outside of the exclusive access) all access to the wallet only
occurs when the lock is held. This is also preferable to acquiring a
private mutex in each of the Wallet's public APIs as it allows
multiple public APIs to be called without any other tasks from
changing wallet state inbetween calls.
The mutex can only be acquired asynchronously. This ensures that the
UI thread never blocks attempting to access wallet state.
Fixes #114.