rpcserver: Remove createrawssgen RPC. #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Sep 12, 2018
alexlyp
approved these changes
Sep 12, 2018
davecgh
force-pushed
the
rpcserver_remove_createrawssgen
branch
from
edfd0fd
to
2da1a42
Compare
This modifies the test code which deals with testing feature deployments to clone the parameters and modify them such that the deployment being tested never expires.
This removes the handler for the createrawssgen RPC and deprecates the associated dcrjson structures. This is being done because it doesn't make any sense for votes to be created over the RPC interface. In order for voting on the previous block to have any semblance of relevance, the software producing the vote clearly must have code to deserialize and understand the relevant data structures.
davecgh
force-pushed
the
rpcserver_remove_createrawssgen
branch
from
2da1a42
to
4a503a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the handler for the
createrawssgenRPC and deprecates the associateddcrjsonstructures.This is being done because it doesn't make any sense for votes to be created over the RPC interface. In order for voting on the previous block to have any semblance of relevance, the software producing the
vote clearly must have code to deserialize and understand the relevant data structures.