txscript: Cleanup opcode removal by data tests. #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Mar 28, 2019
This converts the test definitions for TestRemoveOpcodeByData to make use of mustParseShortForm which improves the readability and construction of the tests as well as makes them more consistent with the rest of the code base. It also cleans up the recently added stake tx tests so that they don't exceed col 80 and sets their names to indicate they are p2pkh and p2sh forms.
davecgh
force-pushed
the
txscript_opcode_data_removal_test_cleanup
branch
from
c15689a
to
f71b0d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the test definitions for
TestRemoveOpcodeByDatato make use ofmustParseShortFormwhich improves the readability and construction of the tests as well as makes them more consistent with the rest of the code base.It also cleans up the recently added stake tx tests so that they don't exceed col 80 and sets their names to indicate they are p2pkh and p2sh forms.