rpcserver: Optimize JSON raw tx input list create. #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit optimizes the createVinList function which is used to generate the JSON list of transaction inputs. It also makes it more consistent with the createVinListPrevOut function. In particular, it entails the following changes: - Only do a single coinbase check and return right away instead of checking multiple times inside the loop over the inputs - Use a pointer for populating the details of each entry to avoid multiple unnecessary array lookups and bounds checks - Group all fields that populate the entry for better readability
|
tACK looks good. can merge after tests are fixed |
|
OK |
davecgh
force-pushed
the
merge_optimize_createvinlist
branch
2 times, most recently
from
8d8d496
to
8ff81ff
Compare
This optimizes the createVinList function which is used to generate the JSON list of transaction inputs. It also makes it more consistent with the createVinListPrevOut function. In particular, it entails the following changes: - Only do a single coinbase check and return right away instead of checking multiple times inside the loop over the inputs - Use a pointer for populating the details of each entry to avoid multiple unnecessary array lookups and bounds checks - Group all fields that populate the entry for better readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Sync from upstream through Sep 30, 2015
This optimizes the
createVinListfunction which is used to generate the JSON list of transaction inputs. It also makes it more consistent with thecreateVinListPrevOutfunction.In particular, it entails the following changes: