peer: Introduce v2 module. #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
approved these changes
Aug 12, 2019
dnldd
reviewed
Aug 12, 2019
dajohi
approved these changes
Aug 12, 2019
This freezes the root module usage of the peer module by removing the replacement and bumping the required version. This means building the software will still produce binaries based on the v1 module until the v2 module is fully released. All future releases will be moving to version 2 of the module. Consequently, it bumps the required module versions as follows: - github.com/decred/dcrd/peer@v1.2.0
This removes the deprecated ChainParams field from the Config struct and updates the tests accordingly. It also removes the dependency on the chaincfg module since it is no longer required.
This modifies the PushGetBlocksMsg and PushGetHeadersMsg functions to accept a string of block loactors hashes instead of a concrete blockchain.BlockLocator to remove the tight couping between the two packages at the API boundary and allow callers to easily provide custom values if desired. It also removes the dependency on the blockchain module since it is no longer required.
This udpates the peer module to use the latest module major versions. The updated direct dependencies are as follows: - github.com/decred/dcrd/txscript/v2@v2.0.0
davecgh
force-pushed
the
peer_introduce_v2
branch
from
0f94a14
to
e523e05
Compare
|
@dnldd Thanks. Updated typo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #1833.
In order to make use of
chaincfg/v2andblockchain/v2, a new major version of thepeermodule is required becausepeer/v1accepts and returns types from bothchaincfg/v1andblockchain/v1in its API.Since a new major version is required, this also takes the opportunity to remove the tight coupling to both
chaincfgandblockchainas follows:*chaincfg.Paramsfrom its API.[]chainhash.Hashfor block locators inPushGetBlocksMsgandPushGetHeadersMsginstead ofblockchain.BlockLocator.Consequently, this introduces
peer/v2. A series of individual commits is provided to make the review process easier. Each commit message more thoroughly describes its purpose, but primarily they consist of the following:peermodule usepeeroverride so building the software will still produce binaries based on thev1module until thev2module is fully releasedConfig.ChainParamsfield[]chainhash.HashinPushGetBlocksMsgandPushGetHeadersMsginstead ofblockchain.Locatorchaincfg.blockchain.v2Finally, it should also be noted that this only introduces the new module and does not update anything to make use of it yet, so building the software will still produce binaries based on the
v1module.