connmgr: Introduce v2 module. #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
approved these changes
Aug 12, 2019
dajohi
approved these changes
Aug 12, 2019
This freezes the root module usage of the connmgr module by removing the replacement and bumping the required version. This means building the software will still produce binaries based on the v1 module until the v2 module is fully released. All future releases will be moving to version 2 of the module. Consequently, it bumps the required module versions as follows: - github.com/decred/dcrd/connmgr@v1.1.0
This modifies the SeedFromDNS function to accept a string of the DNS seeds as well as the default port instead of a concrete chaincfg.Params to remove the tight coupling between the two packages at the API boundary and allow callers to easily provide custom values if desired.
davecgh
force-pushed
the
connmgr_introduce_v2
branch
from
1bbe023
to
9f926ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #1831.
In order to make use of
chaincfg/v2, a new major version of theconnmgrmodule is required becauseconnmgr/v1accepts and returns types fromchaincfg/v1in its API.Since a new major version is required, this also takes the opportunity to remove the tight coupling to
chaincfg, by removing the sole reference to*chaincfg.Paramsin its API.Consequently, this introduces
connmgr/v2. A series of individual commits is provided to make the review process easier. Each commit message more thoroughly describes its purpose, but primarily they consist of the following:connmgrmodule useconnmgroverride so building the software will still produce binaries based on thev1module until thev2module is fully releasedchaincfg.v2Finally, it should also be noted that this only introduces the new module and does not update anything to make use of it yet, so building the software will still produce binaries based on the
v1module.