blockchain: Remove unconfigurable chain var. #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_constant_for_main_block_cache
branch
from
933cdb6
to
b8b3875
Compare
matheusd
approved these changes
Nov 4, 2019
jrick
approved these changes
Nov 4, 2019
This removes the main chain block size instance variable since it is merely set to a constant and is not configurable anyway. While here, it also moves the prune height calculation outside of the loop and renames the variables related to the main chain block cache to be more consistent with the rest of the code.
davecgh
force-pushed
the
blockchain_constant_for_main_block_cache
branch
from
b8b3875
to
6f6403a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the main chain block size instance variable since it is merely set to a constant and is not configurable anyway. While here, it also moves the prune height calculation outside of the loop and renames the variables related to the main chain block cache to be more consistent with the rest of the code.