Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: add --dialtimeout #2068

Merged
merged 3 commits into from
Feb 12, 2020
Merged

multi: add --dialtimeout #2068

merged 3 commits into from
Feb 12, 2020

Conversation

dajohi
Copy link
Member

@dajohi dajohi commented Feb 11, 2020

No description provided.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code look goods, but the new option needs to be added to doc.go and sampleconfig/sampleconfig.go as well.

Timeout specifies the time to wait for a connection to complete before
giving up.
dialtimeout specifies the amount of time for a connection to complete
before giving up.
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to review, I tested this by lowering the timeout to 5, 10, and 15s and intentionally trying to connect to address that have no host on both Windows 10 and Linux.

@davecgh davecgh merged commit aeb0e87 into decred:master Feb 12, 2020
@@ -818,6 +821,15 @@ func loadConfig() (*config, []string, error) {
return nil, nil, err
}

// Don't allow ban durations that are too short.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue, will update this comment in #2047.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants