Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schnorr: Remove generalized Verify. #2123

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Mar 18, 2020

This is rebased on #2122.

This removes the unnecessary generalized Verify function in favor of the Verify method on the Signature to be more consistent with the secp256k1 package.

@davecgh davecgh added this to the 1.6.0 milestone Mar 18, 2020
@davecgh davecgh force-pushed the schnorr_remove_general_verify branch from 58d3a4f to 819c578 Compare March 18, 2020 03:47
Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine though I will say I have a slight preference to Verify being a regular function in the package instead of a method, to match stdlib APIs (and same for secp256k1).

This removes the unnecessary generalized Verify function in favor of the
Verify method on the signature to be more consistent with the secp256k1
package.
@davecgh davecgh force-pushed the schnorr_remove_general_verify branch from 819c578 to e81c95e Compare March 19, 2020 09:24
@davecgh davecgh merged commit e81c95e into decred:master Mar 19, 2020
@davecgh davecgh deleted the schnorr_remove_general_verify branch March 19, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants