Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Split dcrctl to own repo and update docs #2175

Merged
merged 1 commit into from
May 1, 2020

Conversation

jrick
Copy link
Member

@jrick jrick commented Apr 30, 2020

The dcrctl project is being split out of the dcrd repo and module into
its own repo (https://github.com/decred/dcrctl) and module
(decred.org/dcrctl). This commit removes the dcrctl main package and
updates documentation throughout the repo mentioning dcrctl and its
build instructions.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job overall. I see there is still a reference to dcrctl .gitignore that probably should be removed as well.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, while not necessary for this PR, I suspect we should also move the sampleconfig.DcrctlSampleConfig definition over to the new dcrctl repository and update any callers to use that instead.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you want to squash this, I'll get it merged.

The dcrctl project is being split out of the dcrd repo and module into
its own repo (https://github.com/decred/dcrctl) and module
(decred.org/dcrctl).  This commit removes the dcrctl main package and
updates documentation throughout the repo mentioning dcrctl and its
build instructions.
@davecgh davecgh merged commit 787d3f5 into decred:master May 1, 2020
@jrick jrick deleted the rmdcrctl branch May 1, 2020 19:28
@davecgh davecgh added this to the 1.6.0 milestone May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants