peer: Set a default idle timeout if not specified. #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
May 1, 2020
davecgh
force-pushed
the
peer_default_idle_timeout
branch
from
c69a8b3
to
787d3f5
Compare
This modifies the peer initialization code to set a default idle timeout of two minutes if the caller did not specify one. This is desirable since the default is the zero value otherwise, which results in an immediate disconnection for callers that don't specify a timeout. It is worth noting that the server code already has a default setting that can be configured via the command-line or a configuration file which is used to configure the peers, so this has no effect on dcrd, but it is a nice addition for other consumers of the peer package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the peer initialization code to set a default idle timeout of two minutes if the caller did not specify one.
This is desirable since the default is the zero value otherwise, which results in an immediate disconnection for callers that don't specify a timeout.
It is worth noting that the server code already has a default setting that can be configured via the command-line or a configuration file which is used to configure the peers, so this has no effect on
dcrd, but it is a nice addition for other consumers of the peer package.