Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockchain: Correct mempool view construction. #2232

Merged
merged 1 commit into from
Jun 27, 2020
Merged

blockchain: Correct mempool view construction. #2232

merged 1 commit into from
Jun 27, 2020

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Jun 27, 2020 •
edited
Loading

This corrects the construction of the view used by the mempool when dealing with disapproved blocks and includes new tests to ensure the various disapproval combinations work as intended.

It does not affect consensus code.

@davecgh
blockchain: Correct mempool view construction.
01fd2de 
This corrects the construction of the view used by the mempool when
dealing with disapproved blocks and includes new tests to ensure the
various disapproval combinations work as intended.
@davecgh davecgh added this to the 1.6.0 milestone Jun 27, 2020
chappjc
chappjc approved these changes Jun 27, 2020
View reviewed changes
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully synced 4 testnet nodes, and dcrdata, without issue.

matheusd
matheusd approved these changes Jun 27, 2020
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified FetchUtxoView() is only called by the mempool and block template generation code paths and otherwise doesn't cause side-effects in the Blockchain struct, so doesn't cause hard-forking consensus changes.

@davecgh davecgh merged commit 01fd2de into decred:master Jun 27, 2020
@davecgh davecgh deleted the blockchain_correct_mempool_view_construction branch June 27, 2020 15:27
@chappjc chappjc mentioned this pull request Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusd matheusd matheusd approved these changes

@dajohi dajohi dajohi approved these changes

@chappjc chappjc chappjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@davecgh @matheusd @dajohi @chappjc