rpcserver: Handle genesis in getblockchaininfo. #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Jul 2, 2020
davecgh
reviewed
Jul 2, 2020
This updates handleGetBlockchainInfo to properly return blockchain info in the case of an empty blockchain where only the genesis block exists.
rstaudt2
force-pushed
the
getblockchaininfo-empty-blockchain
branch
from
8ed0f4a
to
db6b44d
Compare
matheusd
approved these changes
Jul 2, 2020
davecgh
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates handleGetBlockchainInfo to properly return blockchain info
in the case of an empty blockchain where only the genesis block exists.
Also added tests to cover
handleGetBlockchainInfo.This can be tested manually with an empty blockchain by running
dcrdwith--connect=127.0.0.1(so that it doesn't connect to any peers) and--datadir=~/some-tmp-dirto give it an empty database.Fixes #2235