rpcserver: Use internal quit chan for ws sync. #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Jul 25, 2020
This modifies the websocket notification manager to make use of the newer pattern that synchronizes the Run context with an internal quit channel to ensure that any exported functions that communicate with the goroutines can't possibly hang during shutdown. This was previously done by storing the context in the struct (which is generally discouraged) and protecting it by a mutex which means every single notification had to take the mutex. As can be seen by the diff of this commit, this approach is not only more performant, it's also less code.
davecgh
force-pushed
the
rpcserver_websocket_internal_quit_chan
branch
from
49b58c5
to
a4e2443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the websocket notification manager to make use of the newer pattern that synchronizes the
Runcontextwith an internalquitchannel to ensure that any exported functions that communicate with the goroutines can't possibly hang during shutdown.This was previously done by storing the
contextin the struct (which is generally discouraged) and protecting it by a mutex which means every single notification had to take the mutex.As can be seen by the diff of this commit, this approach is not only more performant, it's also less code.