server: Respond to getheaders when same chain tip. #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
server_getheaders_response_same_tip
branch
from
4ce16df
to
a8fb147
Compare
dnldd
approved these changes
Feb 4, 2021
rstaudt2
approved these changes
Feb 9, 2021
The handler for getheaders currently ignores the request when the chain is not yet believed to be current. This is generally desirable and correct behavior, since it might otherwise lead peers to incorrect conclusions about the state of the peer. However, on private networks, such as simnet, it is not at all uncommon for every node in the network to no longer be current if a block hasn't been mined in a long time or when all nodes are stopped and restarted. In order to better handle these types of edge conditions, this modifies the server to respond to getheaders when the local chain tip is exactly the same as the requested locator even when it is not marked current yet. This results in more robust handling for private networks while still providing the normal desirable behavior prior to being current.
davecgh
force-pushed
the
server_getheaders_response_same_tip
branch
from
a8fb147
to
14adb6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handler for
getheaderscurrently ignores the request when the chain is not yet believed to be current. This is generally desirable and correct behavior, since it might otherwise lead peers to incorrect conclusions about the state of the peer.However, on private networks, such as simnet, it is not at all uncommon for every node in the network to no longer be current if a block hasn't been mined in a long time or when all nodes are stopped and restarted.
In order to better handle these types of edge conditions, this modifies the server to respond to
getheaderswhen the local chain tip is exactly the same as the requested locator even when it is not marked current yet.This results in more robust handling for private networks while still providing the normal desirable behavior prior to being current.