stdaddr: Accept vote and revoke limits separately. #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
stdaddr_calc_limits_in_reward_cmt_script
branch
from
d408079
to
dff23ee
Compare
dnldd
approved these changes
Mar 18, 2021
matheusd
reviewed
Mar 22, 2021
This modifies the RewardCommitmentScript method of the StakeAddress interface to accept the vote and revoke fee limits separately instead of expecting the caller to have already encoded it properly. This simplifies the creation of the reward commitment script since there is not currently any other method available anywhere to independently encode the limits properly and it is not a particularly trivial encoding. Finally, the tests and example are updated accordingly.
davecgh
force-pushed
the
stdaddr_calc_limits_in_reward_cmt_script
branch
from
dff23ee
to
a2366e6
Compare
matheusd
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #2619.
This modifies the
RewardCommitmentScriptmethod of theStakeAddressinterface to accept the vote and revoke fee limits separately instead of expecting the caller to have already encoded it properly.This simplifies the creation of the reward commitment script since there is not currently any other method available anywhere to independently encode the limits properly and it is not a particularly trivial encoding.
Finally, the tests and example are updated accordingly.